Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=460632 --- Comment #1 from Lubomir Rintel <lkundrak@xxxxx> 2008-08-29 08:52:24 EDT --- 0.) You may want to rename it I'm not sure if it is usable only with ircd-ratbox, or other ircds. In case it cannot be used with other ircds, name ircd-ratbox-services is much more appropriate. 1.) Do not depend on sendmail Requires: sendmail Replace with /usr/bin/sendmail or MTA or smtpdaemon, depending on ho do you use sendmail. 2.) Explain non-obvious commands sed 's/-Werror//g' -i configure What's this? Comment it. Provides: perl(definetolength.pl) And this? 3.) Fix owners/groups %config(noreplace) %{_sysconfdir}/logrotate.d/ratbox-services At least this is not to be owned by ircd. Change %defattr to use root by default and override in %attr-s. Furthermore, files that contain password should not be world-readable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review