Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=438750 --- Comment #33 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-08-25 03:02:15 EDT --- For 0.7.5-1.svn: * Versioning/Using svn - When using svn based tarball, please write as comments how you created the tarball: https://fedoraproject.org/wiki/Packaging/SourceURL - Would you tell me whether the tarball you are using is post- or pre- release of version 0.7.5? https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Package_Release - For svn based tarball, I prefer to use revision number rather than the date you checked out. * build log verboseness - Build log output like: -------------------------------------------------------------- 200 [ 41%] 201 Building CXX object src/CMakeFiles/qtoctave.dir/basewidget.o 202 Building CXX object src/CMakeFiles/qtoctave.dir/codeedit.o 203 Building CXX object src/CMakeFiles/qtoctave.dir/variables_list.o 204 Building CXX object src/CMakeFiles/qtoctave.dir/command_list.o 205 [ 43%] -------------------------------------------------------------- is not useful. For example, we cannot check if Fedora specific compiler flags are honored correctly. Please refer to: https://fedoraproject.org/wiki/Packaging/cmake#Specfile_Usage * Icon caching -------------------------------------------------------------- 47 # desktop file can't find icon 48 mkdir $RPM_BUILD_ROOT%{_datadir}/pixmaps 49 mv $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/64x64/apps/%{name}.png \ 50 $RPM_BUILD_ROOT%{_datadir}/pixmaps/%{name}.png 51 rm -rf $RPM_BUILD_ROOT%{_datadir}/icons -------------------------------------------------------------- - Please refer to https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache Resetting fedora-review flag to question mark. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review