Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456298 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #3 from Terje Røsten <terjeros@xxxxxxxxxxxx> 2008-08-21 14:09:22 EDT --- Quick look: o please remove or explain the distribution tag. o I don't see the need for the %nb_ and %nb_ver macros o add the -k option to dos2unix to preserve timestamps o switch from $RPM_BUILD_ROOT to %{buildroot} everywhere. o why define orig_jar, ijardir br_jardir -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review