Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458585 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx --- Comment #2 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-08-19 22:31:01 EDT --- This looks OK; rpmlint has one complaint: cwdaemon.x86_64: W: spurious-executable-perm /usr/share/doc/cwdaemon-0.9.4/cwsetup.sh Normally documentation shouldn't be executable, but it's not really a problem as long as it doesn't cause additional dependencies. I think in this case it causes a /bin/sh dependency which I don't really see as a problem. You seem to be missing the %postun scriptlet; without it, the daemon will not restart itself after a package update. * source files match upstream: 0b26304333a1933d45814be23788295dd22fa6d80fc651a32fb12bd042b9e84e cwdaemon-0.9.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: config(cwdaemon) = 0.9.4-7.fc10 cwdaemon = 0.9.4-7.fc10 cwdaemon(x86-64) = 0.9.4-7.fc10 = /bin/bash /bin/sh /sbin/chkconfig /sbin/service config(cwdaemon) = 0.9.4-7.fc10 libcw.so.0()(64bit) * %check is not present; no way to test this without the proper hardware. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. X scriptlets present look OK, but %postun is missing. * initscript looks OK. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review