Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458457 Marek Mahut <mmahut@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Customer Facing| |--- --- Comment #2 from Marek Mahut <mmahut@xxxxxxxxxx> 2008-08-08 15:14:07 EDT --- (In reply to comment #1) > Marek, thanks for the package. > Actual source file matches upstream. > Mock rebuild succeeded. > Offered functionality was tested. > RPMlint is mostly silent, see below > Uses macros consistently. > > Have you thought about renaming the package to gnuradio-companion? That may > express the relation to gnuradio, and you'll prevent a potential name clash. It > even comes from the same upstream. Probably one day there'll be a lot of grc > packages around :) > > 0.) RPMLint thinks the package should be noarch > > You do not ship any binaries. I do not know if the precompiled python stuff is > arch-independent -- probably worth trying. You're right, this package should be noarch, will be fixed in next revision. > Also, rpmlint complains about shebangs in nonexecutable files. > > 1.) Please do not create scripts inline in SPEC > > That is utterly ugly. You should be ashamed. Any guideline against this? I like it. > 2.) Fix your runtime dependencies. > > You seem to import at least wx, gtk, pango, etc. We do not have autoreqs for > python. Please add the necessary Requires. > > The upstream web [1] recommends the following, which you may want to base your > decision upon: > > * wx-python > * numpy > * gnuradio with gr-wxgui > * python-gtk2(>=2.6) > * python-xml and/or pyxml > > [1] http://gnuradio.org/trac/wiki/GNURadioCompanion All those are fetched with GNURadio itself, this should be fine. > 3.) License tag does not seem correct. > > At least you include some CC blurb in %doc. Are you sure you don't ship any > Creative Commons stuff? Only the icon is under CC, however it's shipped with the package under GPLv2+, should I mention it anyway? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review