Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458030 --- Comment #1 from Thorsten Leemhuis <fedora@xxxxxxxxxxxxx> 2008-08-08 15:13:15 EDT --- just a quick initial review from just looking at the spec file: - > BuildRequires: cmake >= 2.4.5, qt4-devel >= 4.3.0, eigen-devel >= 1.0.5, openbabel-devel >= 2.2.0, python-devel >= 2.5.1 Thats a pretty long line; would look much cleaer if you split it - > Requires: libavogadro = %{version} Are you sure that's needed? RPM will likely add a dep on the libs it needs automatically - the description is quite small (just 55 chars instead off less then 80); no blocker, but looks odd - > %package -n libavogadro I'd say the libs package should be called avogadro-libs -- that's the usual way to name the libs subpackage in Fedora - > # set permissions Please add a comment to the spec file why you do this -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review