Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453520 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx --- Comment #6 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-08-06 04:04:10 EDT --- Some notes before Petersen-san do a full review: * Seemingly redundant version specific (Build)Requires - Please explain why you want version specific (Build)Requires such as glib2-devel > 2.4, splite-devel > 3.0 Even Fedora Core 3 shipped sqlite-3.1.2 and glib2-2.4.7. * Cflags http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags - Fedora specific compilation flags are not correctly honored: http://koji.fedoraproject.org/koji/taskinfo?taskID=761796 And as a result the debuginfo rpm creation is not correct. By the way why do you call cmake twice? * Unihan.h - %_includedir/Unihan.h contains: ----------------------------------------------------------------- 29 #ifndef UNIHAN_H_ 30 #define UNIHAN_H_ 31 #include "config.h" 32 #include "Unihan_enum.h" 33 #include "str_functions.h" ------------------------------------------------------------------ However I can find these 3 headers nowhere. Also please note that installing autotool-generated "config.h" as system-wide header file must be avoided: https://bugzilla.redhat.com/show_bug.cgi?id=208034#c43 * Directory ownership issue - %_datadir/doc/%name is not owned by any packages. By the way, do you really want two document directories: %_datadir/%doc/%name-version and %_datadir/doc/%name ? Please consider to unify document directories. * linkage mistakes - rpmlint shows: ------------------------------------------------------------------- $ rpmlint libUnihan libUnihan.i386: W: undefined-non-weak-symbol /usr/lib/libUnihan.so.0.4 g_free libUnihan.i386: W: undefined-non-weak-symbol /usr/lib/libUnihan.so.0.4 g_free libUnihan.i386: W: undefined-non-weak-symbol /usr/lib/libUnihan.so.0.4 sqlite3_close libUnihan.i386: W: undefined-non-weak-symbol /usr/lib/libUnihan.so.0.4 g_strsplit_set libUnihan.i386: W: undefined-non-weak-symbol /usr/lib/libUnihan.so.0.4 sqlite3_value_int libUnihan.i386: W: undefined-non-weak-symbol /usr/lib/libUnihan.so.0.4 sqlite3_result_text libUnihan.i386: W: undefined-non-weak-symbol /usr/lib/libUnihan.so.0.4 g_strdup ...... (and many) -------------------------------------------------------------------- You can check this also by $ ldd -r /usr/lib/libUnihan.so.0.4 >/dev/null For shipping -devel subpackages this is not allowed because leaving undefined non-weak symbols will cause linkage error. This usually means that libUnihan.so is not correctly linked against proper libraries. Please fix this. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review