Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: primer3 - PCR primer design tool https://bugzilla.redhat.com/show_bug.cgi?id=457038 ------- Additional Comments From pingou@xxxxxxxxxxxx 2008-07-30 09:15 EST ------- (In reply to comment #2) > 1/ It would be fine to keep timestamps while converting README.txt to UTF8 I am using now touch -r COPYING.txt README.txt after the conversion to UTF8. Is it fine ? > 2/ This package doesn't use our RPM_OPT_FLAGS > gcc -c -g -Wall -D__USE_FIXED_PROTOTYPES__ -O2 -DDPAL_MAX_ALIGN=36 > -DMAX_PRIMER_LENGTH=36 primer3_main.c Could you give me some insigth on how I can change this ? > 3/ It seems possible to build a Shared library : > OLIGOTM_DYN_LIB = liboligotm.so.1.2.0 > You can note that this library will probably need to be installed manually as > oligotm.h will probably need the releated liboligotm.a (or .so) to be bundled in > prism3-devel > Do you know any dependent package to test primer3-devel ? Actually, I do not know any. > I guess not all headers will be needed... I would say so to, but since I am not sure I prefered to put them all rather than miss one. > 4/ Make check is usally done in a separate job control (before %clean) > %check > pushd src > %{?_with_tests:make check} > popd added > This will probably need to be conditionalized as some tests take time. > (tested succeded on F-8 x86_64 local rpmbuild - so it's good) > 5/ Why BuildRequires: perl ? > This is in the default buildRequirement, but I wonder why you have added it ? It's the only dependency that I found on the website. I can removed it if it's there by default -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review