Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: primer3 - PCR primer design tool https://bugzilla.redhat.com/show_bug.cgi?id=457038 kwizart@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |kwizart@xxxxxxxxx Flag| |fedora-review? ------- Additional Comments From kwizart@xxxxxxxxx 2008-07-29 11:07 EST ------- - starting review - 1/ It would be fine to keep timestamps while converting README.txt to UTF8 2/ This package doesn't use our RPM_OPT_FLAGS gcc -c -g -Wall -D__USE_FIXED_PROTOTYPES__ -O2 -DDPAL_MAX_ALIGN=36 -DMAX_PRIMER_LENGTH=36 primer3_main.c 3/ It seems possible to build a Shared library : OLIGOTM_DYN_LIB = liboligotm.so.1.2.0 You can note that this library will probably need to be installed manually as oligotm.h will probably need the releated liboligotm.a (or .so) to be bundled in prism3-devel Do you know any dependent package to test primer3-devel ? I guess not all headers will be needed... 4/ Make check is usally done in a separate job control (before %clean) %check pushd src %{?_with_tests:make check} popd This will probably need to be conditionalized as some tests take time. (tested succeded on F-8 x86_64 local rpmbuild - so it's good) 5/ Why BuildRequires: perl ? This is in the default buildRequirement, but I wonder why you have added it ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review