Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: itools - Command line tools for The Islamic Tools and Libraries Project https://bugzilla.redhat.com/show_bug.cgi?id=431186 ------- Additional Comments From kwizart@xxxxxxxxx 2008-07-08 13:55 EST ------- * Package is the last version - OK * Source from website and src.rpm have the same sha1sum - OK b0da901b9f1b4a5410f7ca54049fa28243f444b7 itools-0.6.2.tar.bz2 1/ Source from website and src.rpm have the different timestramps -rw-rw-r-- 1 builder builder 31402 mar 18 2005 itools-0.6.2.tar.bz2 -> You need to use wget -N to download the source tarball 2/ Source URL is wrong - please fix to : http://downloads.sourceforge.net/arabeyes/itools-%{version}.tar.bz2 -> Doing so will use the sf mirrors instead of only one mirror 3/ Providing configure as Source1 is wrong -> You need to BuildRequires autoconf and run autoconf in %prep to avoid to bundle the whole configure script as soon as you modify the configure.in file. 4/ Patch0 could be improved. Instead of using cp you can use cp -p to prevent timestamps changes for the man pages (keeping timestamps for binaries isn't relevant) 5/ COPYING is present within the sources and thus needs to be provided within the %doc 6/ man pages don't need to use the %doc macro. * Build have been tested in mock - (F-9 i386/x86_64 ) OK * rpmlint is clean from both uninstalled and installed packages * Usability has been tested - OK * Install/Uninstall tested - OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review