Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xmp - A multi-format module player https://bugzilla.redhat.com/show_bug.cgi?id=453026 ------- Additional Comments From cra@xxxxxxx 2008-07-01 22:55 EST ------- Looks good with the exception of the OCL-licensed gdm.txt which needs to be addressed. Koji scratch builds: f10: http://koji.fedoraproject.org/koji/taskinfo?taskID=691355 f9: http://koji.fedoraproject.org/koji/taskinfo?taskID=691372 Initial package review: + = passes review item - = fails review item ? = question or clarification needed MUST Items: + rpmlint returns no output + naming is good + spec name matches package name + does not include pre-built binaries or libraries + patches look fine + summary and description looks good + %changelog good + RPM_OPT_FLAGS are being used + debuginfos look good + noreplace is used on config files - License matches source license GPLv2+, however there is a file in the source under Open Content License which is not good: xmp-2.5.1/docs/formats/gdm.txt "This document is Copyright 1999 by MenTaLguY, and can be copied, modified and subsequently redistributed under the terms of the OpenContent Public License as indicated below:" + License COPYING file is packaged as %doc + spec is written in American english + spec is legible + sources match upstream download (no upstream md5/sha1 sums available) sha1sum: 20ce22f453e49adb590b3cbd3ae3e812eb7de4ee xmp-2.5.1.tar.gz + package builds on all supported archs + BuildRequires are good + no locale data, hence no need for %find_lang macro + no libraries in standard paths, hence no requirement for ldconfig in %post + package is not relocatable + owns all directories it creates + no duplicates in %files + good permissions on %files + good %clean section + good buildroot + consistent use of macros + package contains permissable code - package contains content under a bad license: OCL licensed xmp-2.5.1/docs/formats/gdm.txt + no large doc files + docs not required to run, program works without %doc + no header files + no static libs + no pkgconfig files + no suffixed library files (.so.1.1) + no -devel subpackage + no libtool archives (.la) + not a GUI program, .desktop file not needed + does not own paths owned by other packages + rm -rf %{buildroot} at top of %install + valid UTF-8 filenames in package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review