Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rancid - Really Awesome New Cisco confIg Differ https://bugzilla.redhat.com/show_bug.cgi?id=451189 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-06-29 14:26 EST ------- Some ramdom comments: * Licensing - Well, the license of LICENSE.txt as shown on the URL is actually NON-FREE, so the license cannot be accepted on Fedora. However as far as I checked the source tarball, this software is licensed under "BSD with advertising". Note that anyway we don't allow the license tag such as "Freely redistributable without restriction". * Versioning - This package seems to be a pre-version for 2.3.2. In such case the current versioning is wrong. Please refer to: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages * builds - Your package does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=685315 build.log says that at least "ping" binary (in iputils) is missing from BuildRequires. * perl module dependency - When adding perl module dependency as (Build)Requires, please don't write the rpm names directly but write what modules the rpms provide: https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides * Macros - Use macros correctly. For example, /etc must be %{_sysconfdir}. - Also, using the directory %{_prefix}/local is not allowed on Fedora. * Inproper scriptlets - You must call "mkdir" "chown" "ln" "chmod" commands on scriptlets except for very special cases. As same as other packages, for this package you must create the needed directories by the time %install ends, and must add those directories to %files entry and set attribute correctly by using %attr. * Directory ownership issue - Please make it sure that all directories which are created by installing this packages are correctly owned by this package. Currently %{_sysconfdir}/rancid/, %{_datadir}/rancid/ are not owned by any packages. * %changelog version - The EVR (Epoch:Version:Release) number of this package does not coincide with the last entry on %changelog. Please make it sure that when you modify your spec file, you also change the release number of the spec file to avoid confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review