Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libcxgb3 hardware driver https://bugzilla.redhat.com/show_bug.cgi?id=451095 ------- Additional Comments From rpm@xxxxxxxxxxxxxx 2008-06-12 15:25 EST ------- Providing a specfile separately would make reviewer's life easier. Partial specfile review below. > License: GPL/BSD Invalid License tag. Should be: License: GPLv2 or BSD > BuildRequires: libibverbs-devel >= 1.1, autoconf, libtool libtool requires autoconf > ExclusiveArch: i386 x86_64 ia64 ppc ppc64 Do you know for certain it doesn't work on sparc/sparc64? > Obsoletes: %{name}-devel Why? There's no libcxgb3-devel in Fedora. > %install > rm -rf $RPM_BUILD_ROOT > %makeinstall Don't use %makeinstall, use %{__make} install DESTDIR=$RPM_BUILD_ROOT instead (and make sure the Makefile supports DESTDIR for install target). > install -m 644 -D %{SOURCE1} ${RPM_BUILD_ROOT}%{_sysconfdir}/modprobe.d/libcxgb3.conf Use install -p to preserve source timestamps. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review