Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: multiget - A multi-thread http/ftp file downloader https://bugzilla.redhat.com/show_bug.cgi?id=450410 ------- Additional Comments From guido.ledermann@xxxxxxxxxxxxxx 2008-06-12 15:20 EST ------- (In reply to comment #10) > * Source3 > - Please specify the URL of Source3 (or write as a comment > how you received Source3) Wrote a comment in the spec. Actually there isn't an icon provided within the source of 1.2.0. So I took the one from 1.1.4 > * Buildroot > - Please follow > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot Done. > * BuildRequires > - Currently gtk2-devel seems to pull automake, however > for fixing broken install-sh symlink I think explicitly > adding "BuildRequires: automake" is preferred. Fixed. > * Perl module BRs: > - For perl modules BuildRequires, please follow > http://fedoraproject.org/wiki/Packaging/Perl#requiresandprovides > (In short, "BuildRequires: perl-XML-Parser" must be > "BuildRequires: perl(XML::Parser)" ) Fixed. Will be carefully done in future packages. > * Patch0 vs %optflags vs %configure > - You seem to add %Patch0 to honor %optflags, however this Patch0 > is not needed. > The reason your srpm does not honor %optflags is that %configure > is called at %prep, not at %build. Actually %configure sets > CPPFLAGS, however written at %prep, all those variables are > reset. > Move %configure to %build and then Patch0 is no longer needed. Okay. Got it. So this patch is obsolete now. > * Macros > - Use macros. /usr/share must be %{_datadir}. Done. > * Timestamps > - When using "cp" or "install" commands, add "-p" option to keep > timestamps on installed files. Fixed. Find the latest here: Spec URL: http://www.soglatec.de/fedora/multiget.spec SRPM URL: http://www.soglatec.de/fedora/multiget-1.2.0-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review