Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GMT - Generic Mapping Tools https://bugzilla.redhat.com/show_bug.cgi?id=438043 ------- Additional Comments From orion@xxxxxxxxxxxxx 2008-05-12 15:55 EST ------- (In reply to comment #10) > ldconfig call should be in %post, not %pre. Gah, fixed. > There is a \ missing on the find $RPM_BUILD_ROOT/%{gmthome}/examples -name > \*.\*sh | line Not needed - the | works. > Also you could consider removing the .bat files in examples, rpmlint > says: > GMT-examples.i386: W: wrong-file-end-of-line-encoding > /usr/share/GMT/examples/ex03/job03.bat Removed. > There are .in files remaining in > /usr/share/GMT/conf/.gmtdefaults_SI.in > /usr/share/GMT/conf/.gmtdefaults_US.in > /usr/share/GMT/conf/gmt.conf.in > I think they should be removed. You could also consider using the > timestamps of the .in files to have consistent timestamps across arches > for the files in /etc/GMT/ Removed, but I really don't see the need to fix timestamps. > Also maybe the .gmtdefaults_SI and .gmtdefaults_US could be considered > as documentation and linked like other config files in /etc/GMT and as > %config. Done. > Another issue revealed by rpmlint is > GMT-examples.i386: W: doc-file-dependency /usr/share/GMT/examples/ex26/job26.csh > /bin/csh > Maybe the .csh files could be made non executable, and only the > sh files would be executable? Done. > There is also > GMT-octave.i386: E: script-without-shebang > /usr/share/octave/site/api-v32/m/grdinfo.m > GMT-octave.i386: E: script-without-shebang > /usr/share/octave/site/api-v32/m/grdwrite.m > GMT-octave.i386: E: script-without-shebang > /usr/share/octave/site/api-v32/m/grdread.m > because these files have the execute bit set. You should correct it > if it is wrong. Fixed. > A last remaining issue is the soname issue. Any comment on that? Upstream now ships with sonames. * Mon May 12 2008 Orion Poplawski <orion@xxxxxxxxxxxxx> 4.3.0-2 - Add patch to link libraries properly - Run ldconfig in %%post, dummy - Don't ship .bat file - Don't ship .in files - Don't make .csh examples executable - Drop execute bit on .m files Spec URL: http://www.cora.nwra.com/~orion/fedora/GMT.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/GMT-4.3.0-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review