Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GMT - Generic Mapping Tools https://bugzilla.redhat.com/show_bug.cgi?id=438043 ------- Additional Comments From pertusus@xxxxxxx 2008-05-12 14:11 EST ------- ldconfig call should be in %post, not %pre. There is a \ missing on the find $RPM_BUILD_ROOT/%{gmthome}/examples -name \*.\*sh | line Also you could consider removing the .bat files in examples, rpmlint says: GMT-examples.i386: W: wrong-file-end-of-line-encoding /usr/share/GMT/examples/ex03/job03.bat There are .in files remaining in /usr/share/GMT/conf/.gmtdefaults_SI.in /usr/share/GMT/conf/.gmtdefaults_US.in /usr/share/GMT/conf/gmt.conf.in I think they should be removed. You could also consider using the timestamps of the .in files to have consistent timestamps across arches for the files in /etc/GMT/ Also maybe the .gmtdefaults_SI and .gmtdefaults_US could be considered as documentation and linked like other config files in /etc/GMT and as %config. Another issue revealed by rpmlint is GMT-examples.i386: W: doc-file-dependency /usr/share/GMT/examples/ex26/job26.csh /bin/csh Maybe the .csh files could be made non executable, and only the sh files would be executable? There is also GMT-octave.i386: E: script-without-shebang /usr/share/octave/site/api-v32/m/grdinfo.m GMT-octave.i386: E: script-without-shebang /usr/share/octave/site/api-v32/m/grdwrite.m GMT-octave.i386: E: script-without-shebang /usr/share/octave/site/api-v32/m/grdread.m because these files have the execute bit set. You should correct it if it is wrong. A last remaining issue is the soname issue. Any comment on that? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review