Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocaml-pa-monad - OCaml syntax extension for monads https://bugzilla.redhat.com/show_bug.cgi?id=435299 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-05-10 22:00 EST ------- The guidelines don't say much about whether the underscore in the module name needs to be changed to a hyphen. I don't have a particular issue with your naming, and Debian doesn't seem to have this packaged yet so this is sort of blazing new territory. Still, did you give the matter any thought? I'm not seeing the LGPL exception in the package. I suppose it must be there for the package to be useful at all, but I'm not seeing an actual statement of it. There are several test programs; is it possible to run them at build time? I'm certain that the .cmo file is appropriate here, so that's good. It's kind of obvious when there are no other object files in the package. * source files match upstream: eaf67402205208c1bb34dda6d12b2f87e1b5dc7781cbf9c03dcf6c14d9e4fd5a pa_monad.tar.gz ? package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. ? license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: ocaml(Pa_monad) = 0772e3866372127d528565bcf7904b7b ocaml-pa-monad = 1.2.0-1.fc9 = ocaml(Arg) = 03e86a4154064ea900dc32c05f53e364 ocaml(Array) = aa8e3cd5824f9bb40b93fcd38d0c95b5 ocaml(Buffer) = f6cef633ea14963b84b79c4095c63dc3 ocaml(Camlp4) = 1e46a133b8062d1571640f7fa36f32c4 ocaml(Camlp4_config) = cb716b4361f43326c6ad695c7a1bb5c0 ocaml(Camlp4_import) = 0134ca95282ef6821081c0c11802cea0 ocaml(Char) = e98bc9c9e918a84b3c1a5a122d42fac1 ocaml(Filename) = 633a1e7f590ff5e95124293dbef3b476 ocaml(Format) = 35fe566f7a37d8991a5c822bd1463949 ocaml(Hashtbl) = 083f2c94b44ff4e0b3220aaea6a783b4 ocaml(Int32) = 711321870c949bd3bbdd092d9bae92e4 ocaml(Int64) = f8f7e2e4c0667ead94596040b12e732d ocaml(Lexing) = b1793496643444d3762dd42bebe2cfe3 ocaml(List) = da1ce9168f0408ff26158af757456948 ocaml(Nativeint) = e79cdc4d3575c2ed044955cb7ef49aca ocaml(Obj) = 5cfae708052c692ea39d23ed930fd64d ocaml(Parsing) = 62cca107e4e88af303516459a87c3e9a ocaml(Pervasives) = 8ba3d1faa24d659525c9025f41fd0c57 ocaml(Printf) = 5dbbf45a03b54e6dbfcf39178d0d6341 ocaml(Queue) = caa3a209bfc63d23a30f573541a88fec ocaml(Set) = 7da14e671a035f12386ace3890018ef3 ocaml(Stream) = 21a833e12efd34ea0c87d8d9da959809 ocaml(String) = 2c162ab314b2f0a2cfd22d471b2e21ab ocaml(Sys) = 0da495f5a80f31899139359805318f28 ocaml(runtime) = 3.10.1 X %check is not present, but test code seems to be available. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * most of the package is documentation, but it's still only a few K so there's no point in splitting it. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review