Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fpm2 - Password manager with GTK2 GUI https://bugzilla.redhat.com/show_bug.cgi?id=444830 ------- Additional Comments From als@xxxxxxxxx 2008-05-08 07:01 EST ------- (In reply to comment #5) > In %files you write: > %{_datadir}/fpm2/pixmaps/* > > But then the directories %{_datadir}/fpm2 and %{_datadir}/fpm2/pixmaps, will > not be owned by any package and will be left behind after package removal, so > instead you should write just: > %{_datadir}/fpm2 > > In %files, then rpmbuild will automatically own the dir, and include (and own) > all files and dirs under that. Yes, you right. I fix it. > Also doesn't the menu entry have an icon? Or is the icon under > /usr/share/fpm2/pixmaps, and then referenced with an absolute path from > the .desktop? Menu entry have icon and is referenced with absolute path. As wrote in packaging guidelines this is acceptable. FPM2 don't have true icon, it is own logo with 115x56 size and let gnome to scale it itself. You think this is bad way and I must create single 48x48 icon? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review