Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fpm2 - Password manager with GTK2 GUI https://bugzilla.redhat.com/show_bug.cgi?id=444830 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC|j.w.r.degoede@xxxxxx | OtherBugsDependingO|177841 | nThis| | AssignedTo|nobody@xxxxxxxxxxxxxxxxx |j.w.r.degoede@xxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-05-08 05:52 EST ------- Ok, lets review this then. Here are the results of just checking the spec file (not behind a Linux machine atm). In %files you write: %{_datadir}/fpm2/pixmaps/* But then the directories %{_datadir}/fpm2 and %{_datadir}/fpm2/pixmaps, will not be owned by any package and will be left behind after package removal, so instead you should write just: %{_datadir}/fpm2 In %files, then rpmbuild will automatically own the dir, and include (and own) all files and dirs under that. --- Also doesn't the menu entry have an icon? Or is the icon under /usr/share/fpm2/pixmaps, and then referenced with an absolute path from the .desktop? If that is the case thats rather ugly imho, instead the icon should be installed under /usr/share/icons/hicolor/48x48/apps And referenced by just its name (without extension) from the .desktop file, when you do this you must also add icon-cache update scripts to the specifle as described here: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets? action=show&redirect=ScriptletSnippets#head- 7103f6c38d1b5735e8477bdd569ad73ea2c49bda Note that if the icon is a different size then 48x48, you should ofcourse change 48x48 in the installation path. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review