Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: GMT - Generic Mapping Tools https://bugzilla.redhat.com/show_bug.cgi?id=438043 ------- Additional Comments From orion@xxxxxxxxxxxxx 2008-04-29 13:30 EST ------- (In reply to comment #4) > Could it be possible to have the doc package submitted in parallel? GMT-docs package review is bug 444625 > You should look at my package for the removal of a non-free > file. Added. Upstream has committed to releasing a "free source" version next release. > I find the octave patch a bit strange, since it uses matlab > support. Could it be possible to have it additionally, such that > it can be submitted upstream? I mentioned it upstream, but I think upstream needs to move to using autotools (or cmake or similar) in the src/mex directory first to allow for build time configuration. > Your octave packaging is not the same than the one proposed at: > http://fedoraproject.org/wiki/PackagingDrafts/Octave > but at that page there are mistakes. Yeah, but this is not a "real" octave package. > There is no soname in the shared libs. Do you really want to > ship them? I think it is very wrong. I've added a patch to use .0 soname. Thoughts? I've mentioned the issue upstream, but it seems a bit above their heads. > The octave define at the beginning should be ameliorated, I get, > without octave-devel: > $ rpmbuild -ba GMT.spec > sh: octave-config: command not found > sh: octave-config: command not found > sh: octave-config: command not found > sh: octave-config: command not found > sh: octave-config: command not found > sh: octave-config: command not found > sh: octave-config: command not found > error: Failed build dependencies: > octave-devel is needed by GMT-4.2.1-2.i386 Redirected stderr to /dev/null. > I propose to have xgridedit in a separate package, to avoid depending > on the X libs. Okay. > less is detected at build time and used in the GMT script at runtime. Fixed > There are many config files in %_datadir that cannot be overriden by > the user. They should be in %_sysconfdir and marked %config(noreplace). Added. > > Also I have a sed substitution to correct the doc path in the GMT > command. Added. > I suggest adding INSTALL='install -p' to the make install command to > keep timestamps as much as possible. Done. > Also during install, cp is called as cp -r for installation of data. > I would suggest either substituting cp -r to cp -pr, redoing the install > or doing a patch for the Makefile to keep timestamps. Added patch > I suggest doing in %prep: > > chmod a-x src/ps2raster.c src/mgd77/mgd77sniffer.c Fixed. > pslib is a badly choosed name, it could interfere with other library names. > I did: > # rename the pslib man page > mv $RPM_BUILD_ROOT%{_mandir}/man3/pslib.3 $RPM_BUILD_ROOT%{_mandir}/man3/GMT_pslib.3 It doesn't conflict at the moment. Perhaps better to work with upstream to get it renamed? > The examples should certainly be %doc, even if they are in a separate > package, since they are really %doc, and we don't want them to be > installed if docs are excluded. Sure. > The html docs should be in the main package, they are very small. Done. I had thought they were duplicates before. > The src/*/README.* should also be in %doc. > > I think that it would be better to have a %dist tag. Oversight (from all the other noarch GMT packages). > I think that the examples should have a > Requires: %{name} = %{version}-%{release} > such that there cannot be any mismatch which could cause the examples > to fail. Fixed. > I propose adding to main package > %doc gmt_bench-marks added Spec URL: http://www.cora.nwra.com/~orion/fedora/GMT.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/GMT-4.2.1-3.fc9.src.rpm * Tue Apr 28 2008 Orion Poplawski <orion@xxxxxxxxxxxxx> 4.2.1-3 - Remove unfree source - Split out xgridedit into sub-package - Add BR and R on less - Redirect octave-config stderr to /dev/null - Move config files to /etc/GMT - Use install -c -p to preserve timestamps - Use cp -pr to copy share data - Add sonames to shared libraries -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review