Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: adonthell - A 2D graphical RPG game https://bugzilla.redhat.com/show_bug.cgi?id=441411 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxxxx ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-04-25 14:06 EST ------- Some comments: * As far as I checked the tarball, the license tag should be "GPLv2+". * The explicit Requires: ----------------------------------------------------------------- Requires: SDL Requires: python Requires: zlib Requires: freetype Requires: SDL_mixer ------------------------------------------------------------------ should all be removed. These library related Reqires are automatically checked and added to binary rpms by rpmbuild itself. * Fedora specific compilation flags (you can check this by $ rpm --eval %optflags) are not correctly honored: the section "Compiler flags" of http://fedoraproject.org/wiki/Packaging/Guidelines * Please check directory ownership issue ------------------------------------------------------------------ [root@localhost ~]# LANG=C rpm -qf /usr/share/adonthell/modules/adonthell.pyc adonthell-0.3.4-0.7.fc9.i386 [root@localhost ~]# LANG=C rpm -qf /usr/share/adonthell file /usr/share/adonthell is not owned by any package [root@localhost ~]# LANG=C rpm -qf /usr/share/adonthell/modules/ file /usr/share/adonthell/modules is not owned by any package ------------------------------------------------------------------ Note: When you write ------------------------------------------------------------------ %files %{_datadir}/%{name}/ ------------------------------------------------------------------ This contains the directory %_datadir/%name itself and all files/directories/etc under the directory, while ------------------------------------------------------------------ %files %dir %{_datadir}/%{name} ------------------------------------------------------------------ contains the directory %{_datadir}/%name only. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review