Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sugar-journal - Journal activity for sugar https://bugzilla.redhat.com/show_bug.cgi?id=444158 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tcallawa@xxxxxxxxxx 2008-04-25 14:05 EST ------- Review ========= Good: - rpmlint checks return: * sugar-journal.noarch: W: non-standard-group Sugar/Activities * sugar-journal.src: W: non-standard-group Sugar/Activities * sugar-journal.src: W: strange-permission sugar-journal-checkout.sh 0775 All safe to ignore. - package meets Sugar naming guidelines - package meets Sugar packaging guidelines - license (GPLv2+) OK, copy of license not in source, matches source code - spec file legible, in am. english - source generated with included script - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED (please make sure the new sugar-toolkit package is tagged and in the repodata before rebuilding) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review