Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libyahoo2 - Library for the Yahoo! Messenger Protocol https://bugzilla.redhat.com/show_bug.cgi?id=433925 ------- Additional Comments From lemenkov@xxxxxxxxx 2008-04-03 14:26 EST ------- Sorry for the delay, Ray. Some remarks before review. * You must specify full path to source's tarball, not only %{name}-%{version}.tar.bz2. For SF-hosted projects we have special requirements for %Source field - take a look at this page (at the bottom): http://fedoraproject.org/wiki/Packaging/SourceURL * You should change your BuildRoot to something like BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * Change these two lines: iconv -c -t UTF8 AUTHORS > AUTHORS.utf8 || : iconv -c -t UTF8 NEWS > NEWS.utf8 %{__mv} AUTHORS.utf8 AUTHORS %{__mv} NEWS.utf8 NEWS I recommend you to use something like: iconv -c -t UTF8 AUTHORS > AUTHORS.utf8 && %{__mv} AUTHORS.utf8 AUTHORS because if iconv fails you won't destroy all contents of your original file. Not a very probable scenario but still... * Create a backups of patched files by using key -b. For example: %patch0 -p1 -b .fh %patch1 -p1 -b .protocol Other things looks sane. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review