Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-StackTrace - Display a stack trace on the Catalyst debug screen https://bugzilla.redhat.com/show_bug.cgi?id=439152 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-03-27 08:12 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=534017 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4bd2dc12f9b6f6bb310c1fe07a8321f1 Catalyst-Plugin-StackTrace-0.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 3 tests skipped. Files=9, Tests=24, 2 wallclock secs ( 1.88 cusr + 0.13 csys = 2.01 CPU) +Package perl-Catalyst-Plugin-StackTrace-0.07-2.fc9 => Provides: perl(Catalyst::Plugin::StackTrace) = 0.07 Requires: perl >= 0:5.008001 perl(Devel::StackTrace) perl(HTML::Entities) perl(NEXT) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) SHOULD: 1)Try adding line to enable tests in %check export TEST_POD=1 MUST: 1) Drop redundant BR BuildRequires: perl >= 1:5.8.1 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review