Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Model-LDAP - LDAP model class for Catalyst https://bugzilla.redhat.com/show_bug.cgi?id=439142 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-03-27 08:06 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=534006 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0ccbf7239d3bed85fe3f588a28a5c268 Catalyst-Model-LDAP-0.16.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 7 tests skipped. Files=9, Tests=8, 2 wallclock secs ( 1.25 cusr + 0.05 csys = 1.30 CPU) + Package perl-Catalyst-Model-LDAP-0.16-2.fc9 => Provides: perl(Catalyst::Helper::Model::LDAP) perl(Catalyst::Model::LDAP) = 0.16 perl(Catalyst::Model::LDAP::Connection) perl(Catalyst::Model::LDAP::Entry) perl(Catalyst::Model::LDAP::Search) Requires: perl(Carp) perl(Catalyst::Model::LDAP::Search) perl(Class::C3) perl(Data::Page) perl(Net::LDAP::Constant) perl(Net::LDAP::Control::Sort) perl(Net::LDAP::Control::VLV) perl(base) perl(strict) perl(warnings) SHOULD: Try adding line to enable tests in %check export TEST_POD=1 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review