Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: java-1.6.0-openjdk - The OpenJDK 1.6.0 runtime environment https://bugzilla.redhat.com/show_bug.cgi?id=433070 ------- Additional Comments From fitzsim@xxxxxxxxxx 2008-03-09 12:32 EST ------- (In reply to comment #16) > Just a few comments/issues I see: > > - Why the Epoch: 1? Yes, we'll have to add a comment to the spec file about this. This is required because of an oversight in JPackage that was brought into RHEL. Here's the comment we'll add: # java-1.5.0-ibm from jpackage.org set Epoch to 1 for unknown reasons, # and this change was brought into RHEL-4. java-1.5.0-ibm packages # also included the epoch in their virtual provides. This created a # situation where in-the-wild java-1.5.0-ibm packages provided "java = # 1:1.5.0". In RPM terms, "1.6.0 < 1:1.5.0" since 1.6.0 is # interpreted as 0:1.6.0. So the "java >= 1.6.0" requirement would be # satisfied by the 1:1.5.0 packages. Thus we need to set the epoch in # JDK package >= 1.6.0 to 1, and packages referring to JDK virtual # provides >= 1.6.0 must specify the epoch, "java >= 1:1.6.0". > > - Does %{?_smp_mflags} not work? If not, might add a comment about it... if it > does, it would speed up building a good amount. No, OpenJDK's Makefiles don't support -j. I'll add a comment in the spec file that we should fix this upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review