Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tomcat6 - Apache Servlet/JSP Engine, RI for Servlet 2.5/JSP 2.1 API https://bugzilla.redhat.com/show_bug.cgi?id=435829 ------- Additional Comments From dwalluck@xxxxxxxxxx 2008-03-04 22:52 EST ------- - use %%{_initrddir} macro instead of %%{_sysconfdir}/init.d (rhbz #153187) I would think that the definition of %{_initrddir} in Fedora may be incompatible with the LSB, but that this should not affect its use within spec files in accordance with bug #153187 comment #2. - update initscript (rhbz #247077) This is in accordance with http://fedoraproject.org/wiki/FCNewInit/Initscripts which required implementing different return values and some additional arguments. - remove file-based requires One issue with regard to JPackage is that Fedora ships update-alternatives in the chkconfig package but does not provide update-alternatives as a virtual. The others are probably safe. I don't think that file-based requires violate Fedora policy as long as they are located in certain directories, but I preferred to change them. - fix strange-permission rpmlint wants all sources to be shipped in the SRPM to be mode 0644, and then for example, the initscript may be made executable in the %files list instead. This does not refer to the uid/gid and modes necessary to run as the tomcat user which is normal for servers such as these. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review