Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tomcat6 - Apache Servlet/JSP Engine, RI for Servlet 2.5/JSP 2.1 API https://bugzilla.redhat.com/show_bug.cgi?id=435829 ------- Additional Comments From jason.corley@xxxxxxxxxxxxxxxx 2008-03-04 20:24 EST ------- Going through the changelog since I didn't catch up with you on IRC. - use %%{_initrddir} macro instead of %%{_sysconfdir}/init.d (rhbz #153187) incorrect given that LSB currently mandates /etc/init.d (http://refspecs.linux-foundation.org/LSB_3.2.0/LSB-Core-generic/LSB-Core-generic/initsrcinstrm.html) - fix incorrect initscript output (rhbz #380921) portability issue, can't be done for JPackage - update initscript (rhbz #247077) confused by this one, we've had LSB comments for quite a while... incorrect number? - add logrotate support you don't want to do this, logging in tomcat 6.x (and 5.5.x) is done via log4j and already has log rotation, you'll just end up with a nice full directory of 0kb .XX.gz files (which is why it was removed from 6.x in the first place) - remove file-based requires same portability comment as above - fix strange-permission which one? there's a bunch (I'm guessing) and they generally have reasons... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review