Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: timidity++ https://bugzilla.redhat.com/show_bug.cgi?id=226492 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-03-03 11:29 EST ------- For 2.13.2-13: * Patches merge - Please merge the patches which can be merged (especially a patch and a patch to the patch, e.g. Patch(0) and Patch16) * License - Now License tag is just GPLv2. * Macros - Unify macros usage. For example (I have not checked all macros usage inconsistency) ------------------------------------------------------- echo "soundfont /usr/share/soundfonts/PCLite.sf2" > \ $RPM_BUILD_ROOT/%{_sysconfdir}/timidity++.cfg ...... %config(noreplace) /etc/timidity++.cfg ------------------------------------------------------- echo "soundfont /usr/share/soundfonts/PCLite.sf2" > \ $RPM_BUILD_ROOT/%{_sysconfdir}/timidity++.cfg (From PersonalCopy-Lite-soundfont:) %{_datadir}/soundfonts ------------------------------------------------------- - For hardcoded /etc, please also check my comment 2. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review