Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: distcc - Distributed C/C++ compilation https://bugzilla.redhat.com/show_bug.cgi?id=433228 ------- Additional Comments From ville.skytta@xxxxxx 2008-02-18 12:50 EST ------- - LSB comment block missing, see http://fedoraproject.org/wiki/PackagingDrafts/SysVInitScript - Incorrect exit status (per LSB spec) when /usr/bin/distccd is not installed: should be 5 when $1 != status. What is this check needed for, BTW? - The init script does not appear to make any checks whether we're in a required configured state or not, which will probably lead to another incorrect exit status per the LSB spec and I guess a suboptimal error message. When unconfigured, exit status should be 6 when $1 != status. See for example how the vdr and hddtemp packages handle this more gracefully. - No profile.d snippet to have distcc in use out of the box? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review