https://bugzilla.redhat.com/show_bug.cgi?id=2346787 --- Comment #18 from Attila Kovacs <attipaci@xxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/xchange/fedora-rawhide-x86_64/08744760-libxchange/libxchange.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/xchange/fedora-rawhide-x86_64/08744760-libxchange/libxchange-1.0.0.rc5-1.fc43.src.rpm Thanks Benson, - I changed the spec file to use the `%{_includedir}` macro. - Updated to the latest release candidate upstream (1.0.0.rc5) I've mulled over the suggestion of putting the headers files into a package sub-directory. However, after having slept on it, I decided against it. It's just two header files, both of which are named uniquely enough that it is unlikely to run into naming conflicts. And if some future package does conflict, oh well, it will be up to them to put their headers into a sub-folder to distinguish. Keeping them in %{_includedir} directly, provides easier access to them in general, and causes less divergence between linking against the upstream vs. the Fedora package. So in the end, the latter won the debate for me. cheers, -- A. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2346787 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202346787%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
