[Bug 2349303] Review Request: python-safetensors - Python bindings for the safetensors library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2349303

Alexander Lent <lx@xxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(lx@xxxxxxxxxxxxxx |
                   |)                           |



--- Comment #4 from Alexander Lent <lx@xxxxxxxxxxxxxx> ---
Thanks for asking about combining the packages. I think it's an interesting
idea that might reduce issues with version mismatches, but the Rust SIG folks
had recommended split packages for policy reasons.

I put the question to the Rust SIG folks on matrix who had recommended the
split approach, and they cite the Rust packaging guidelines on the subject:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Rust/#_package_sources
Namely, their guidelines effectively require that all rust-somepackage packages
come from the crates.io sources for somepackage, for consistency and ease of
maintenance on the Rust side.

Additionally, the argument was made that the Python bindings are not so tightly
integrated: since they *can* be patched to depend on the Rust package instead
of using bundled sources, they *must* be so patched, per the bundled sources
packaging guidelines:
https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling

I think both of these arguments are reasonable in terms of maintainability,
with the burden mostly falling on the maintainer (presumably myself) of
python-safetensors to keep the version in sync, and the Rust folks continuing
to maintain the rust-safetensors package with their procedures.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2349303

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202349303%23c4

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux