Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cstream - General-purpose stream-handling tool https://bugzilla.redhat.com/show_bug.cgi?id=432080 ------- Additional Comments From rhbugs@xxxxxxxxxxxxxxxx 2008-02-09 17:10 EST ------- 1) Of course. Added. 2) The Makefile.am remarks that the tests do not work (due to the output format being slightly different). I'd presume running them at %check time or shipping them as docs does not make sense, then. 3) Can a double -Wall hurt? Adding "-Wall -Wextra -Werror" makes it clear which set of warnings/errors we want, so that's what I'd go for. Compilation should be done before "make install", so I do not deem it necessary to define the CFLAGS there. Updated package at http://ndim.fedorapeople.org/cstream/2.7.4-4.fc8/ * Sat Feb 09 2008 Hans Ulrich Niedermann <hun@xxxxxxxxxxxxxxxx> - 2.7.4-4 - Add %%{?dist} to Release: * Fri Feb 08 2008 Hans Ulrich Niedermann <hun@xxxxxxxxxxxxxxxx> - 2.7.4-3 - More compile warnings (-Wall -Wextra -Werror). - Redacted description down to the most important points. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review