Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cstream - General-purpose stream-handling tool https://bugzilla.redhat.com/show_bug.cgi?id=432080 ------- Additional Comments From panemade@xxxxxxxxx 2008-02-09 04:43 EST ------- 1)you may like to add distag to release as Release: 3%{?dist} 2)good if you add tests to %doc that will create rpmlint warning to silent it add to %prep chmod 644 tests/test1.sh 3) CFLAGS value is CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables' So you don't need to add -Wall. Also, any reason to add "-Wextra -Wno-unused-parameter -Werror" to make install? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review