https://bugzilla.redhat.com/show_bug.cgi?id=2325933 --- Comment #20 from Jakub Jelen <jjelen@xxxxxxxxxx> --- > 1. The SourceLicense is GPL-3.0-or-later, but this license doesn't show up in the License tag for the built package. That shouldn't be possible. This is the license of the project itself: https://github.com/latchset/kryoptic/blob/main/LICENSE.txt Seems like I did not manage to put it into the License field correctly. In generated LICENSE.dependencies I can see it is correctly. I will update it. > 2. You're using the wrong GitHub archive (i.e. zip), the correct ones (.tar.gz) are documented here: > https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_revision > i.e. it should be https://github.com/latchset/kryoptic/archive/%{revision}/kryoptic-%{revision}.tar.gz Thanks for the pointer! Will fix with the next update! > 2. What is "BuildRequires: openssl-devel" for? This should not be necessary if this uses the Rust OpenSSL bindings. It does not use the Rust OpenSSL bindings. It is linking to the openssl directly for reasons. > 3. I'm not sure if this actually works: > > > CONFDIR=%{_sysconfdir} %cargo_build -f dynamic,nssdb,standard > > since %cargo_build uses a subshell. > > I would recommend to do this instead: > > > export CONFDIR=%{_sysconfdir} > > %cargo_build -f dynamic,nssdb,standard Thank you! Will change! > 4. You can also just skip %cargo_install macro and the "rm .../conformance" calls entirely - building and installing the executable just to delete it again is pointless. We still install the %{_bindir}/softhsm_migrate which should land from this command. > 5. The unversioned .so in %{_libdir} is not a minor annoyance, it's wrong. Even the pkcs11 docs say to install it under %{_libdir}/pkcs11/. > > > install -Dp target/rpm/libkryoptic_pkcs11.so $RPM_BUILD_ROOT/%{_libdir}/libkryoptic_pkcs11.so > > %{_libdir}/libkryoptic_pkcs11.so > > Should be > > > install -Dp target/rpm/libkryoptic_pkcs11.so $RPM_BUILD_ROOT/%{_libdir}/pkcs11/libkryoptic_pkcs11.so > > %{_libdir}/pkcs11/libkryoptic_pkcs11.so > > see https://docs.fedoraproject.org/en-US/packaging-guidelines/Pkcs11Support/#_registering_the_modules_system_wide Thank you! Will fix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2325933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325933%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
