https://bugzilla.redhat.com/show_bug.cgi?id=2325933 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #18 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There's several things that are strange and / or wrong in the spec file: 1. The SourceLicense is GPL-3.0-or-later, but this license doesn't show up in the License tag for the built package. That shouldn't be possible. 2. You're using the wrong GitHub archive (i.e. zip), the correct ones (.tar.gz) are documented here: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_commit_revision i.e. it should be https://github.com/latchset/kryoptic/archive/%{revision}/kryoptic-%{revision}.tar.gz 2. What is "BuildRequires: openssl-devel" for? This should not be necessary if this uses the Rust OpenSSL bindings. 3. I'm not sure if this actually works: > CONFDIR=%{_sysconfdir} %cargo_build -f dynamic,nssdb,standard since %cargo_build uses a subshell. I would recommend to do this instead: > export CONFDIR=%{_sysconfdir} > %cargo_build -f dynamic,nssdb,standard 4. You can also just skip %cargo_install macro and the "rm .../conformance" calls entirely - building and installing the executable just to delete it again is pointless. 5. The unversioned .so in %{_libdir} is not a minor annoyance, it's wrong. Even the pkcs11 docs say to install it under %{_libdir}/pkcs11/. > install -Dp target/rpm/libkryoptic_pkcs11.so $RPM_BUILD_ROOT/%{_libdir}/libkryoptic_pkcs11.so > %{_libdir}/libkryoptic_pkcs11.so Should be > install -Dp target/rpm/libkryoptic_pkcs11.so $RPM_BUILD_ROOT/%{_libdir}/pkcs11/libkryoptic_pkcs11.so > %{_libdir}/pkcs11/libkryoptic_pkcs11.so see https://docs.fedoraproject.org/en-US/packaging-guidelines/Pkcs11Support/#_registering_the_modules_system_wide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2325933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325933%23c18 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
