https://bugzilla.redhat.com/show_bug.cgi?id=2338679 --- Comment #9 from Stefano Brivio <sbrivio@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #8) > Thanks! Looks good to me now. Two minor things: Thanks for re-reviewing (and re-re-reviewing, too). > 1) Please replace "%license LICENSE" with "%license > %{crate_instdir}/LICENSE", otherwise the file will be included in the > package twice. I would also put the link to the upstream PR next to the > Source file for the LICENSE (that's the part that would raise questions), > not where it's used (which is normal). Oops. Anyway, not needed anymore, because: > 2) Upstream has released version 0.6.0 in the meantime. ...which includes my LICENSE symlink. It's 0.6.1 now. > Is what you're > working on explicitly depending on v0.5, or has it bumped its dependency on > const-str / const-str-macro to 0.6.0 already? You don't need to update to > 0.6.0 if you need 0.5, I'm just asking to make sure you're working on the > correct version to avoid more work. It's a dependency that I'm unfortunately introducing in muvm (https://github.com/AsahiLinux/muvm/pull/111), and 0.6.1 works just fine. Spec URL: https://passt.top/static/rust-const-str-proc-macro.spec SRPM URL: https://passt.top/static/rust-const-str-proc-macro-0.6.1-1.fc42.src.rpm Description: Compile-time string operations Fedora Account System Username: sbrivio -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2338679 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338679%23c9 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
