https://bugzilla.redhat.com/show_bug.cgi?id=2338679 --- Comment #8 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks! Looks good to me now. Two minor things: 1) Please replace "%license LICENSE" with "%license %{crate_instdir}/LICENSE", otherwise the file will be included in the package twice. I would also put the link to the upstream PR next to the Source file for the LICENSE (that's the part that would raise questions), not where it's used (which is normal). 2) Upstream has released version 0.6.0 in the meantime. Is what you're working on explicitly depending on v0.5, or has it bumped its dependency on const-str / const-str-macro to 0.6.0 already? You don't need to update to 0.6.0 if you need 0.5, I'm just asking to make sure you're working on the correct version to avoid more work. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2338679 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202338679%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
