https://bugzilla.redhat.com/show_bug.cgi?id=2334903 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Assignee|decathorpe@xxxxxxxxx |nobody@xxxxxxxxxxxxxxxxx Status|ASSIGNED |NEW --- Comment #10 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > # Need to disable build from stripping debug > %global debug_package %{nil} You should only need this if the built executables actually have no debuginfo. And if that is the case, something is wrong with the compiler flags that are getting passed. > There's some precedent in river for just providing plain bundled(<dep>) = <version> for the zig dependencies as it reflects what the package manager zon names dependencies for zig, > and they suggest a "bundled(zon(<dep>)) = <version>" syntax if we want to add metadata. I think the latter form should be preferred. The one without "namespacing" doesn't really make sense, it usually refers to package names that already exist in Fedora. Other language ecosystems also use syntax like "bundled(crate(foo)) = 1.2.3" or "bundled(golang(github.com/foo/bar)) = 2.3.4" since this matches the virtual Provides that those crates / Go libraries *would* have if they were packaged instead of bundled. I also tried to find documentation for "zon", but I couldn't find anything relevant. Is this a builtin tool of the zig toolchain or some third-party package manager for zig? I found no references to it in https://github.com/ziglang at all. That said, I'm clearly not responding to updates in this ticket in a timely manner, so I'd like to step aside and let someone else continue with the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2334903 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334903%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
