https://bugzilla.redhat.com/show_bug.cgi?id=2309375 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #10 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Sorry about the delay. This slipped through the cracks in the post-holiday madness :( The package looks good to me, with one minor RFE: Use `%license %{crate_instdir}/LICENSE` in %files instead of `%license LICENSE`. The way you do it know will result in the LICENSE file being included twice in the package. You can fix that before importing the package. Another thing of note is that the upstream project seems to have published a rather large number of new versions, the latest is 2.0.2, while this review is for 0.9.0. I won't block the review on this, but just wanted you to be aware. Feel free to drop by in the #rust:fedoraproject.org room on Matrix if you need help with anything! (It also looks like newer versions include the LICENSE file in the published .crate sources, so that's good too.) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass 🫤 latest version of the crate is packaged (not a blocker) ✅- license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (temporarily manually included from upstream git, newer versions contain the file in the published crates) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2309375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202309375%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
