https://bugzilla.redhat.com/show_bug.cgi?id=2337050 --- Comment #3 from Steve Cossette <farchord@xxxxxxxxx> --- (In reply to Elliott Sales de Andrade from comment #2) > The URL appears to be for a different project. > > Instead of `convert_version`, I would name it `tag` and use Lua to avoid an > external process: > %global tag %{lua: print("SPEECHPROVIDER_" .. string.gsub(macros.version, > "%.", "_"))} > > As noted by fedora-review, headers should go in a `-devel` package, as > should pkgconfig. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages > > Does the shared library not set a soversion? > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_downstream_so_name_versioning > > Is `cmake` really needed, as the build system is `meson`, and there are no > CMake dependencies listed? > > Also consider using %autorelease/%autochangelog. 1- My logic for not making a -devel subpackage is that this package itself is a subpackage. There is no shared libraries it would seem. 2- cmake is indeed necessary. Build fails if it's not provided. 3- Using autorelease/autochangelog has drawbacks and I usually avoid it. I'll look into the macro in a bit -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2337050 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202337050%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
