https://bugzilla.redhat.com/show_bug.cgi?id=2337050 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #2 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- The URL appears to be for a different project. Instead of `convert_version`, I would name it `tag` and use Lua to avoid an external process: %global tag %{lua: print("SPEECHPROVIDER_" .. string.gsub(macros.version, "%.", "_"))} As noted by fedora-review, headers should go in a `-devel` package, as should pkgconfig. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Does the shared library not set a soversion? https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning Is `cmake` really needed, as the build system is `meson`, and there are no CMake dependencies listed? Also consider using %autorelease/%autochangelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2337050 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202337050%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
