[Bug 2318425] Review Request: ollama - Get up and running with Llama 3.2, Mistral, Gemma 2, and other large language models

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2318425



--- Comment #14 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> ---
Sorry, I was too fast in my previous comment. There other things to fix also:

> [ ]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/lib64/ollama/bin/dist/linux-
>      amd64/lib/ollama/runners/cpu, /usr/lib64/ollama/bin/dist/linux-amd64,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners/cpu_avx,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners/cpu_avx2,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama,
>      /usr/lib64/ollama/bin, /usr/lib64/ollama/bin/dist/linux-amd64/lib,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners/rocm,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners,
>      /usr/lib64/ollama/bin/dist
> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/lib64/ollama/bin,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners/cpu_avx2,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib,
>      /usr/lib64/ollama/bin/dist, /usr/lib64/ollama/bin/dist/linux-
>      amd64/lib/ollama, /usr/lib64/ollama/bin/dist/linux-
>      amd64/lib/ollama/runners/rocm, /usr/lib64/ollama/bin/dist/linux-
>      amd64/lib/ollama/runners, /usr/lib64/ollama/bin/dist/linux-amd64,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners/cpu_avx,
>      /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners/cpu

Check
https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/

You may need to add the following to take ownership of the paths:

%dir /usr/lib64/ollama
%dir /usr/lib64/ollama/bin
%dir /usr/lib64/ollama/bin/dist
%dir /usr/lib64/ollama/bin/dist/linux-amd64
%dir /usr/lib64/ollama/bin/dist/linux-amd64/lib
%dir /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama
%dir /usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/runners


> Development (unversioned) .so files in -devel subpackage, if present.
>     Note: Unversioned so-files in private %_libdir subdirectory (see
>     attachment). Verify they are not in ld path.

It refers to this path:
/usr/lib64/ollama/bin/dist/linux-amd64/lib/ollama/libggml_rocm.so

> %{_libdir}/ollama/bin/dist/linux-amd64/lib/ollama/libggml_rocm.so
> %{_libdir}/ollama/bin/dist/linux-amd64/lib/ollama/runners/{cpu,cpu_avx,cpu_avx2,rocm}/ollama_llama_server

Should rocm installs be checked with `%if %{with rocm}`?


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2318425

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202318425%23c14

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux