https://bugzilla.redhat.com/show_bug.cgi?id=2318425 --- Comment #13 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- I think the spec is correct and will post the review and approval in a separate comment, but before pushing to the repo please change the following cosmetic suggestions: > BuildRequires: make > BuildRequires: fdupes > BuildRequires: gcc-c++ Order alphabetically > %if %{with rocm} > BuildRequires: rocm-comgr-devel > BuildRequires: rocm-hip-devel > BuildRequires: rocminfo > BuildRequires: rocblas-devel > BuildRequires: hipblas-devel > BuildRequires: rocm-runtime-devel > BuildRequires: rocm-compilersupport-macros > > Requires: rocblas > Requires: hipblas > %endif Order alphabetically > # we do not build for gfx940 or gfx941 Can briefly describe why? > %{_libdir}/ollama/bin/dist/linux-amd64/lib/ollama/runners/{cpu,cpu_avx,cpu_avx2,rocm}/ollama_llama_server > %{_libdir}/ollama/bin/{ollama,runner} Can you add a line per entry? it can make things like grep easier. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2318425 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202318425%23c13 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
