https://bugzilla.redhat.com/show_bug.cgi?id=2334082 Jeremy Newton <alexjnewt@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |alexjnewt@xxxxxxxxxxxx Status|NEW |ASSIGNED --- Comment #2 from Jeremy Newton <alexjnewt@xxxxxxxxxxxx> --- So it seems like you copied a lot of this from rocdecode, which is fine, but you should update it a bit. E.g.: - I noticed that the line mentioning that rocdecode pull > Allow overriding CMAKE_CXX_COMPILER: is probably not applicable in the develop branch because of: https://github.com/ROCm/rocJPEG/commit/4e78bca06adcce207dab336853f26af4d7dad036 Since it now only sets it if the value isn't already set. You can just mention it's resolved upstream instead of putting that link. - For the find libva issue, you can either drop the link to that rocDecode issue link or just note this is a similar issue to that issue. It seems like Also I noticed: > [ ]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 4577280 bytes in /usr/share Not sure what is considered "large" but 4.5 mb is probably fine. Nothing else stood out to me, we can probably push it through if you update the above. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2334082 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334082%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
