[Bug 2334841] Review Request: rust-libphosh-sys - Rust bindings for libphosh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2334841



--- Comment #6 from me@xxxxxxxxxxx ---
0. Oops xD

1. Yeah I was mostly trying to placate fedora-review-service. I suspected
something like what you're saying, but couldn't see the compiler dep when I
went looking at the rust package. Guess I just didn't look carefully enough ;)
I'll remove this unnecessary dep in the next revision.

2. Interesting, guess I didn't run into the inconsistency because I've only
been building against aarch64/x64 in COPR

3. Ah, right. Oops! I'll add a rust2rpm.toml per your suggestion and fix this
up, thanks.

4. I see, I'll do that in the next revision. Interestingly I've already done
this in some local changes that build rust-libphosh-sys 0.0.5, but I can't
submit that yet because libphosh 0.44 hasn't made its way into the repos.

I'll push up a new revision soon, thanks for the review!


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2334841

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334841%23c6

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux