https://bugzilla.redhat.com/show_bug.cgi?id=2334841 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value Flags| |fedora-review? CC| |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks mostly OK, with some minor things: 0. Don't mix tabs and spaces in the same file. :) 1. Why did you manually add "BuildRequires: gcc"? If it's to placate some warning, you can ignore it - the Rust compiler already hard-codes a dependency on gcc. 2. "ExcludeArch: i686" is better written as "ExcludeArch: %{ix86}" to avoid problems with systems that define this differently (it's i686 in koji but i386 in COPR, IIRC). 3. You also need to add "Requires: libphosh-devel" to the "devel" subpackage, otherwise it won't be pulled in when building packages that depend on libphosh-sys. 4. Replace "%license LICENSE" with "%license %{crate_instdir}/LICENSE" to avoid including the LICENSE file in built packages twice. You might be interested in also adding a rust2rpm.toml config file to automate some parts of this package. For example, this snippet would cause the dependency on libphosh-devel to be automatically injected where required: ``` [requires] build = ["libphosh-devel"] lib = ["libphosh-devel"] ``` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2334841 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202334841%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
