https://bugzilla.redhat.com/show_bug.cgi?id=2330455 --- Comment #6 from Kyle Gospodnetich <me@xxxxxxxxxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/kylegospo/ig/fedora-41-x86_64/08430824-golang-github-inspektor-gadget/golang-github-inspektor-gadget.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/kylegospo/ig/fedora-41-x86_64/08430824-golang-github-inspektor-gadget/golang-github-inspektor-gadget-0.34.0-1.fc41.src.rpm Thank you for the review! I've addressed these issues in the following ways: - The BPF templates are referenced in the upstream repository as being licensed with "GPL-2.0-only WITH Linux-syscall-note" so I think you need to add that to the License list if those are included in the build. -- This is now fixed via manual specification of the license for the LICENSE-bpf.txt file - The Golang packaging guide says the description "MUST stay within 80 characters per line". The description is already wrapped in the macro so you should be able to line-wrap safely with no additional changes needed. -- Fixed - You might be able to use %autosetup (https://rpm-software-management.github.io/rpm/manual/autosetup.html) which is about the same except it defaults to -q and automates any patch applications necessary. You're not currently carrying patches, but in the event that you do, it's easy to forget to apply them and autosetup can help there. -- go vendor tools requires %setup, more details can be found here: https://fedora.gitlab.io/sigs/go/go-vendor-tools/example-specfile/ I have added %autopatch to handle any future need for patches - rpmlint is unhappy about the length of the Summary field (although it doesn't say how long is too long) -- Fixed - The tools/ and hack/ directories inside usr/share/licenses/golang-github-inspektor-gadget seem like they're not intended to be there -- This has been fixed by removing them ahead of build time since they are unnecessary - Since you're not using the %{gobuild} macro I think you're missing some compiler flags. -- %gobuildflags is now used during the build. %gobuild should also work, but there appears to be an issue with the environment when using that macro that causes some dependencies to be ignored. I will take this up in the Go Matrix but hopefully this is not a showstopper. Let me know if there's anything else I could improve on, and thanks again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2330455 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202330455%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
