https://bugzilla.redhat.com/show_bug.cgi?id=2330455 Jeremy Cline <jeremy@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy@xxxxxxxxxx --- Comment #5 from Jeremy Cline <jeremy@xxxxxxxxxx> --- This isn't an "official" review since I'm not very familiar with Golang generally and the go-vendor-tools in particular, so I'm going to leave it to someone more knowledgeable to approve this :) Here's a few things I noticed in my review: - The BPF templates are referenced in the upstream repository as being licensed with "GPL-2.0-only WITH Linux-syscall-note" so I think you need to add that to the License list if those are included in the build. - The Golang packaging guide says the description "MUST stay within 80 characters per line". The description is already wrapped in the macro so you should be able to line-wrap safely with no additional changes needed. - You might be able to use %autosetup (https://rpm-software-management.github.io/rpm/manual/autosetup.html) which is about the same except it defaults to -q and automates any patch applications necessary. You're not currently carrying patches, but in the event that you do, it's easy to forget to apply them and autosetup can help there. - Since you're not using the %{gobuild} macro I think you're missing some compiler flags. Unfortunately I don't know much about the Go build process so I can't offer helpful suggestions here, but if at all possible you should use the macro or you'll not pick up new flags as the distro adds them. rpmlint has complaints like: - golang-github-inspektor-gadget.x86_64: W: position-independent-executable-suggested /usr/bin/ig and it looks like the %{gobuild} macro includes "-buildmode pie", for example. That might also fix the issue with the build ID since it seems to include some stuff around that. - rpmlint is unhappy about the length of the Summary field (although it doesn't say how long is too long) - The tools/ and hack/ directories inside usr/share/licenses/golang-github-inspektor-gadget seem like they're not intended to be there (since it's under the licenses directory and it's a collection of shell scripts). I think this is also causing the rpm to depend on /usr/bin/bash. The only really concerning thing to me is the missing compile flags. I tried to replace `go build` with the macro and it was not happy: ... Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.QEUM7t + umask 022 + cd /builddir/build/BUILD/golang-github-inspektor-gadget-0.34.0-build + cd inspektor-gadget-0.34.0 + CGO_ENABLED=0 ++ echo golang-github-inspektor-gadget-0.34.0-1.fc42-1732665600 ++ sha1sum ++ cut -d ' ' -f1 + GOPATH=/builddir/build/BUILD/golang-github-inspektor-gadget-0.34.0-build/inspektor-gadget-0.34.0/_build:/usr/share/gocode + GO111MODULE=off + go build -buildmode pie -compiler gc '-tags=rpm_crashtraceback ' -a -v -x -ldflags ' -X github.com/inspektor-gadget/inspektor-gadget/version=0.34.0 -B 0xabebcba177d6f34e0e25026a244c9db42a1ba62c -compressdwarf=false -linkmode=external -extldflags '\''-Wl,-z,relro -Wl,--as-needed -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes '\''' WORK=/tmp/go-build3108905485 package .: no Go files in /builddir/build/BUILD/golang-github-inspektor-gadget-0.34.0-build/inspektor-gadget-0.34.0 RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.QEUM7t (%build) Bad exit status from /var/tmp/rpm-tmp.QEUM7t (%build) But I'm not sure what invocation it wants, exactly. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2330455 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202330455%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
