Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libtune - standard API to access the kernel tunables https://bugzilla.redhat.com/show_bug.cgi?id=210007 konradr@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From konradr@xxxxxxxxxx 2008-02-04 18:10 EST ------- ok MUST items with explanations: - rpmlint: ok $rpmlint -v libtune-0.14-5.fc8.i386.rpm libtune.i386: I: checking $rpmlint -v libtune-devel-0.14-5.fc8.i386.rpm libtune-devel.i386: I: checking libtune-devel.i386: W: service-default-enabled /etc/rc.d/init.d/chtunedb libtune-devel.i386: W: service-default-enabled /etc/rc.d/init.d/chtunedb libtune-devel.i386: W: incoherent-init-script-name chtunedb $rpmlint -v tunables-base-data-2.6.23-0.14-5.fc8.i386.rpm tunables-base-data-2.6.23.i386: I: checking $rpmlint -v tunables-distro-data-0.14-5.fc8.i386.rpm tunables-distro-data.i386: I: checking The warnings for libtune-devel can be ignored. The 'chtunedb' script is the mechanism for the devel package to "harvest" kernel parameters (so if a new kernel is added they are automaticly regenerated). ok MUST items: - package name: ok. - spec file name match base package: ok. - package meet packaging guidelines: ok - package must contin approved license: ok - license field equal the actual license: ok - spec file written in American English: ok - spec file legible: ok - source files in rpmbuild match upstream: ok - package compile and build binary RPM: ok (built on f-7, f-8, f-9 under scratch koji build) - build dependencies listed in BuildRequires: ok - binary RPM which stores shared library must call ldconfig in %post and %postun: ok - a package must own all the directories it creates: ok - a package must not contain duplicates in %files: ok - permissions must be properly: ok - must have %clean section: ok - must use consistently use macros: ok - package must contain code or permissiable content: ok - if a package includes %doc it must not reflect the runtime of the application: ok - header files must be in -devel package: ok - if package contains library files with a suffix, then one ending with .so must be in -devel: ok - fully versioned depedency: ok - not have any .la archives :ok - package must not own files or directories already owned by other packages: ok - At the beginning of %install, the rm -Rf .. : ok - all filenames in the package must be valid UTF-8: ok N/A MUST items: - spec file handle locales using %find_lang: There are no translation usages on this package, hence N/A. - if package is relocatable ....: Package is not relocatable, hence N/A. - large doc should go in -doc subpackage .. : no big doc, hence N/A. - static libraries must be in .. : not using static libraries, hence N/A. - packages containing pkgconfig(..), not using pkgconfig, hence N/A. - package containing GUI .. : no GUI, hence N/A. ok SHOULD items with explanations. - usually subpackages other than devel should require the base package using a fully versioned dependency. This package 'libtune' requires the 'tunabled-base-distro-%{version}' package instead of using the 'tunable-base-distro-%{version}-${release}'. This is done b/c the tunables-base-distro package can be respun many times during a release (for new kernels that might change their /proc or /sysfs layout) and there is absolutely no reason to re-release the libtune package. ok SHOULD items: - if the source package does not include license text... : it does have it: ok - test package in koji: ok - compile and build binary packages on all architecture: ok - test the package functions as described: ok - if scriptlets are used... : ok. N/A SHOULD items: - The placement of pkgconfig ... : N/A - If the package has file dependency on .. : N/A - The description and summary sections in the package should contain translations for supported Non-English language: not done. This package does not contain any localized information, hence no translation effort was involved and this is N/A. PACKAGE REVIEWED. ACCEPT. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review